Genotyping data derived from genotyping plate (display, download, delete) #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
isaak
approved these changes
Apr 14, 2025
| $where_clause = "nd_experiment_protocol.nd_protocol_id = $genotyping_protocol_id"; | ||
| } | ||
|
|
||
| my $q = "SELECT nd_experiment_genotype.nd_experiment_id, nd_experiment_genotype.genotype_id, nd_experiment_protocol.nd_protocol_id |
There was a problem hiding this comment.
What happens if you call the delete_genotype_data function without any of ids...may be check at least one of them is passed to the delete object before making the query to avoid runtime error...
lib/CXGN/Genotype/Delete.pm
Outdated
|
|
||
| if ($genotyping_plate_id) { | ||
| my @plate_list = (); | ||
| @plate_list = ($genotyping_plate_id); |
lukasmueller
requested changes
Apr 15, 2025
lib/CXGN/Genotype/Delete.pm
Outdated
| } elsif ($genotyping_project_id) { | ||
| $where_clause = "nd_experiment_project.project_id = $genotyping_project_id"; | ||
| } elsif ($genotyping_protocol_id) { | ||
| $where_clause = "nd_experiment_protocol.nd_protocol_id = $genotyping_protocol_id"; |
There was a problem hiding this comment.
We should try to use only placeholders in sql statements. Could you replace the embedded variables with placeholders (?) ?
There was a problem hiding this comment.
@lukasmueller I have been using placeholders in all cases, except this type of statements "join ("," , @$sample_list)", because it doesn't work with the placeholder.
|
@isaak Thanks Isaak. I fixed both requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.