Add Spatial correction to mixed model - sommer #5400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaak
reviewed
Apr 7, 2025
isaak
approved these changes
Apr 7, 2025
Fixing typo on MixedModels.pm line 76
cmn92
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
before running the model, I suggest checking the factors to ensure they have levels 2 or more because sommer complains when it only has one unique value with this error "Error in contrasts<-(tmp, value = contr.funs[1 + isOF[nn]]) :
contrasts can be applied only to factors with 2 or more levels". we could exclude those factors.
| print(paste("FIXED MODEL :", fixed_model)) | ||
| print(paste("RANDOM MODEL: ", random_model)) | ||
| print(paste("FIXED FACTORS: ", fixed_factors)) | ||
| print(paste("RANDOM FACTORS: ", random_factors)) |
There was a problem hiding this comment.
before running the model, I suggest checking the factors to ensure they have levels 2 or more because sommer complains when it only has one unique value with this error "Error in contrasts<-(*tmp*, value = contr.funs[1 + isOF[nn]]) :
contrasts can be applied only to factors with 2 or more levels". we could exclude those factors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.