Topic/repetitive measurements2 #5233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d UI elements for downloads; adapt code to changes.
change xpath selectors due to moving of the wizard loading div
scroll column 4 type select into view before clicking
…ut is required fir ontology root trait, method, scale terms
fix typos and add to pod .xls format requirement for input file
…store() function by introducing new accessors in that object; add more to the repetitive measurements test.
ryan-preble
requested changes
Apr 9, 2025
dwaring87
requested changes
Apr 15, 2025
There was a problem hiding this comment.
You may want to increase the folder number for the DB Patch since this number has already been used
| my $end_time = $params->{observationTimeStampRangeEnd}->[0] || undef; | ||
| my $start_date = $params->{observationTimeStampRangeStart}->[0] || undef; | ||
| my $end_date = $params->{observationTimeStampRangeEnd}->[0] || undef; | ||
| my $repetitive_measurements_type = $params->{repetitiveMeasurements_type} || 'average'; #use default to average |
There was a problem hiding this comment.
Is repetitiveMeasurements_type part of the BrAPI spec?
|
|
||
| =cut | ||
|
|
||
| sub store { |
There was a problem hiding this comment.
there are a lot of print STDERR lines in this sub
There was a problem hiding this comment.
the my keyword on line 233 is causing the trait_cvterm variable to be undefined later on since the variable is already declared on line 220
There was a problem hiding this comment.
The variable trait_property_names on line 116 is missing trait_repeat_type, without this the cvterm prop is not stored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #5201, #5152 , #5271, #3878, #4419, #3630
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.