-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendorize dependencies using govend #11
Conversation
Manually verified using a fresh, empty Go workspace that this PR successfully removes library dependency requirements from the sample app:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit I didn't look through all 1,044,092 lines ;) but the structure looks good. This means though we have pinned to certain vendor versions. Will we be updating the vendor code regularly and how would we do that?
@cce I hit grpc/grpc-go#566 when I tried this branch, and I think anyone else that already imports their own copy of The workaround isn't too tricky, though it's a little messy: users that hit that issue could just delete this vendored copy of grpc and use their own. |
That's too bad — I was hoping to avoid issues with customers that have |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage 76.01% 76.01%
=======================================
Files 21 21
Lines 2289 2289
=======================================
Hits 1740 1740
Misses 499 499
Partials 50 50 Continue to review full report at Codecov.
|
I no longer think this is a good idea — closing. |
Use vendored dependencies for protobuf, grpc, pkg/errors, and bson by running: