chore(wire): add check_len to all parse methods #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvdveld
force-pushed
the
add-check-length-to-parse
branch
from
4930de4 to
abef4e9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
==========================================
- Coverage 79.77% 79.71% -0.06%
==========================================
Files 78 78
Lines 28133 28060 -73
==========================================
- Hits 22443 22369 -74
- Misses 5690 5691 +1 ☔ View full report in Codecov by Sentry. |
“Invalid”? |
|
Oh damn, yes, that's what I wanted to write... |
This commit adds a call to `check_len` to all parse methods in the `wire` module. This ensures that no accessor methods are invalid, helping the compiler in optimizing.
thvdveld
force-pushed
the
add-check-length-to-parse
branch
from
abef4e9 to
892d4d9
Compare
crawford
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a call to
check_lento all parse methods in thewiremodule. This ensures that no accessor methods are invalid, helping the compiler optimise.server: 199.4KiB -> 197.3KiB
client: 200.2KiB -> 198.0KiB
sixlowpan: 196.8KiB -> 194.7KiB
It's a small gain, but it's worth it.
Edit: valid -> invalid