Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tcp): add missing feature to test #872

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

thvdveld
Copy link
Contributor

#867 was merged with failing tests. Somehow, github allowed this. I thought the merge queue was going to prevent that.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (73ac7a4) 79.58% compared to head (080ca4f) 79.74%.
Report is 13 commits behind head on main.

Files Patch % Lines
src/wire/ieee802154.rs 73.57% 37 Missing ⚠️
src/iface/interface/sixlowpan.rs 77.77% 2 Missing ⚠️
src/iface/interface/ipv6.rs 88.88% 1 Missing ⚠️
src/iface/interface/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   79.58%   79.74%   +0.16%     
==========================================
  Files          78       78              
  Lines       28122    28137      +15     
==========================================
+ Hits        22380    22439      +59     
+ Misses       5742     5698      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thvdveld
Copy link
Contributor Author

@Dirbaio could you check in branch protection if "Only merge non-failing pull requests" is checked for merge queues?

@Dirbaio
Copy link
Member

Dirbaio commented Dec 11, 2023

no idea what happened. required tests are configured like this

screenshot-2023-12-11_11-25-44

and the tests job depends on all tests. it shows as "skipped", no idea how could github consider it success...??

@thvdveld
Copy link
Contributor Author

@Dirbaio
Copy link
Member

Dirbaio commented Dec 11, 2023

yes, that's checked :|

@thvdveld thvdveld added this pull request to the merge queue Dec 11, 2023
Merged via the queue into smoltcp-rs:main with commit c647a32 Dec 11, 2023
23 checks passed
@thvdveld thvdveld deleted the fix-tcp-test branch December 11, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants