Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some redundant code #1032

Closed
wants to merge 2 commits into from
Closed

Conversation

ususdei
Copy link

@ususdei ususdei commented Jan 14, 2025

Just some automatically applied suggestions from clippy 0.1.84.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (74bd1e5) to head (13605ac).

Files with missing lines Patch % Lines
src/iface/interface/ipv4.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   80.88%   80.88%   -0.01%     
==========================================
  Files          81       81              
  Lines       28452    28447       -5     
==========================================
- Hits        23013    23008       -5     
  Misses       5439     5439              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitequark
Copy link
Contributor

I think this change doesn't really provide value, only adds churn.

@ususdei
Copy link
Author

ususdei commented Jan 14, 2025

It doesn't add much by itself, agreed.
Maybe just someone else would get annoyed by the warnings.
Other than that I just think, a clean codebase with fewer distractions makes development easier.
But it is going to converge anyway. I just have to wait until MSRV hits 1.84. ;-)

@ususdei ususdei closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants