feat: Automatically join solicited-node multicast addresses #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergzand
changed the title
bergzand
force-pushed
the
pr/join_solicited_node
branch
from
fd9a473 to
508b16c
Compare
|
One effect of this pr is that an ethernet-based interface wants to send out multicast reports as soon as an IPv6 address is configured. Not sure if there's strong opinions on that. |
Dirbaio
force-pushed
the
pr/join_solicited_node
branch
from
508b16c to
1027f4f
Compare
Dirbaio
reviewed
Nov 27, 2024
src/iface/interface/multicast.rs
Outdated
| .filter_map(|group_addr| match group_addr { | ||
| IpAddress::Ipv6(address) | ||
| if address.is_solicited_node_multicast() | ||
| && self.inner.has_solicited_node(*address) => |
There was a problem hiding this comment.
should be && !has_solicited_node(...) . fixed it for you.
IPv6 over Ethernet should join the solicited-node multicast addresses required by the configured IPv6 addresses, as neighbor solicitations for these addresses have the solicited-node multicast address as destination address. This commit automatically leaves old solicited-node multicast addresses and joins the new set when the IP addresses on the interface are updated.
Dirbaio
force-pushed
the
pr/join_solicited_node
branch
from
c53d175 to
0385bad
Compare
Dirbaio
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 over Ethernet should join the solicited-node multicast
addresses required by the configured IPv6 addresses, as neighbor
solicitations for these addresses have the solicited-node multicast
address as destination address.
This commit automatically leaves old solicited-node multicast addresses
and joins the new set when the IP addresses on the interface are
updated.