-
Notifications
You must be signed in to change notification settings - Fork 222
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test for httpLabel/httpQuery escaping
Smithy recently amended the HTTP label spec to clarify the set of characters that must be escaped. But, due to a peculiarty of the spec, it Smithy ommitted the `%` character from this set which definitely needs to be escaped. This diff updates the spec and adds exhaustive test cases for both. These tests have been run on and pass the Rust SDK protocol test suite. (They also went the other way, I had 2 bugs caused by copy-paste errors converting the Smithy set to the percent encoding set used by the Rust SDK). Exhaustive tests are important here, because I suspect other SDKs may have similar copy-paste errors, furthermore, several of these characters, namely: `:()!,` may not be escaped by a "out of the box" protocol coder but these are known to cause problems when sent to AWS services.
- Loading branch information
Showing
3 changed files
with
35 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters