Add sSDK runtime support for NodeJS. #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pose
commented
Mar 1, 2023
gosar
reviewed
Mar 1, 2023
| @@ -0,0 +1,53 @@ | |||
| /* | |||
| * Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Don't need the year. See #692 (though I'm not sure the checkstyle is being applied to ts files)
There was a problem hiding this comment.
Checkstyle is only checking java files: https://github.com/awslabs/smithy-typescript/blob/main/config/checkstyle/checkstyle.xml#L26
There was a problem hiding this comment.
I'll adapt the files I'm creating or modifying to use the short-form license form:
/*
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/
Comment on lines
30
to
28
| const url = new URL(req.url || "", `http://${req.headers.host}`); | ||
| return new HttpRequest({ | ||
| method: req.method, | ||
| headers: convertHeaders(req.headers), | ||
| query: converQueryString(url.searchParams), | ||
| path: url.pathname, | ||
| body: req, | ||
| }); |
There was a problem hiding this comment.
I'm not much familiar with NodeJS's http module, so not deeply verifying that use of url and body are appropriate, but seems reasonable, as long as they work in your testing.
pose
force-pushed
the
features/node-server-support
branch
from
29a8c12 to
1eb75dd
Compare
srchase
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds initial (and very basic) sSDK runtime support for NodeJS. This is still missing a ton of testing: It was tested locally using a simple sSDK project.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.