Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement @range on long and byte shapes #2036

Merged
merged 8 commits into from
Nov 29, 2022
Merged

Implement @range on long and byte shapes #2036

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
703b6a4
Group all override-related test cases together.
LukeMathWalker Nov 29, 2022
7ffc6e6
Add @range examples for both byte and long in constraints.smithy.
LukeMathWalker Nov 29, 2022
b7c0353
Implement @range for long and byte shapes.
LukeMathWalker Nov 29, 2022
1f885d8
Update CHANGELOG
LukeMathWalker Nov 29, 2022
bd2aa02
Fix unit tests.
LukeMathWalker Nov 29, 2022
ee98851
Address comments
LukeMathWalker Nov 29, 2022
21a3bec
Dry up further.
LukeMathWalker Nov 29, 2022
d758859
Merge branch 'main' into range-long
LukeMathWalker Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG
  • Loading branch information
@LukeMathWalker
LukeMathWalker committed Nov 29, 2022
commit 1f885d88fe4073c9285c04fde1f6062821877e79
6 changes: 4 additions & 2 deletions CHANGELOG.next.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,15 +242,17 @@ message = """

* The `length` trait on `string` shapes.
* The `length` trait on `map` shapes.
* The `range` trait on `integer` shapes.
* The `range` trait on `byte` shapes.
* The `range` trait on `short` shapes.
* The `range` trait on `integer` shapes.
* The `range` trait on `long` shapes.
* The `pattern` trait on `string` shapes.

Upon receiving a request that violates the modeled constraints, the server SDK will reject it with a message indicating why.

Unsupported (constraint trait, target shape) combinations will now fail at code generation time, whereas previously they were just ignored. This is a breaking change to raise awareness in service owners of their server SDKs behaving differently than what was modeled. To continue generating a server SDK with unsupported constraint traits, set `codegenConfig.ignoreUnsupportedConstraints` to `true` in your `smithy-build.json`.
"""
references = ["smithy-rs#1199", "smithy-rs#1342", "smithy-rs#1401", "smithy-rs#2005", "smithy-rs#1998", "smithy-rs#2034"]
references = ["smithy-rs#1199", "smithy-rs#1342", "smithy-rs#1401", "smithy-rs#2005", "smithy-rs#1998", "smithy-rs#2034", "smithy-rs#2036"]
meta = { "breaking" = true, "tada" = true, "bug" = false, "target" = "server" }
author = "david-perez"

Expand Down