Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added post-processing script to allow for conditional inclusion of gcode #3391

Closed
wants to merge 1 commit into from

Conversation

lordofhyphens
Copy link
Member

Addresses #3390

@lordofhyphens lordofhyphens added the Feature request This is an idea for a new feature in Slic3r label Jul 1, 2016
@lordofhyphens lordofhyphens added this to the 1.3.5 milestone Jul 1, 2016
@lordofhyphens lordofhyphens self-assigned this Jul 1, 2016
@lordofhyphens
Copy link
Member Author

I need to do some more research, but here's a basic script in the utils directory to perform the conditional gcode. I need to do some more research to figure out what is considered to be in path at all times for Slic3r w/r/t packaging; which would let me add this the default list of post-processing scripts.

I think additionally the interface for post-processing scripts needs to be cleaned up a bit, with a nicer UI for saving them and a clean way to reorder ones that are being applied.

@lordofhyphens
Copy link
Member Author

Syntax is going to change and this is instead going into the C++/XS side of the fence re: preferences @alexrj (and I agree enough to not waste time arguing about it). Closing; this PR does represent a large security hole in Slic3r; a maliciously crafted config.ini could execute code on your system.

@lordofhyphens lordofhyphens deleted the conditional-gcode branch November 6, 2018 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request This is an idea for a new feature in Slic3r
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant