Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update managed jobs docs #4665

Merged
merged 5 commits into from
Feb 8, 2025
Merged

update managed jobs docs #4665

merged 5 commits into from
Feb 8, 2025

Conversation

cg505
Copy link
Collaborator

@cg505 cg505 commented Feb 7, 2025

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cg505 cg505 mentioned this pull request Feb 7, 2025
5 tasks
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cg505!

docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Show resolved Hide resolved
@@ -245,27 +275,6 @@ Real-World Examples
* PyTorch Lightning DDP, CIFAR-10: `YAML <https://github.com/skypilot-org/skypilot/blob/master/examples/spot/lightning_cifar10.yaml>`__


.. _on-demand:

Managed On-Demand/Reserved Jobs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's keep this in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tag referenced by anything?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, don't see any. There was a reference at the top of the page but it's also removed in this PR.

@cg505 cg505 requested a review from concretevitamin February 8, 2025 00:17
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cg505 for this!

@@ -245,27 +275,6 @@ Real-World Examples
* PyTorch Lightning DDP, CIFAR-10: `YAML <https://github.com/skypilot-org/skypilot/blob/master/examples/spot/lightning_cifar10.yaml>`__


.. _on-demand:

Managed On-Demand/Reserved Jobs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tag referenced by anything?


.. code-block:: console
.. image:: ../images/managed-jobs-dashboard.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Note the filter by status line: the yellow box is super transparent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure what's up with that. I will just merge this as is and try to get a better screenshot later.

docs/source/running-jobs/many-jobs.rst Outdated Show resolved Hide resolved
@cg505 cg505 enabled auto-merge (squash) February 8, 2025 02:56
@cg505 cg505 merged commit 54fe787 into master Feb 8, 2025
18 checks passed
@cg505 cg505 deleted the managed-jobs-docs branch February 8, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants