Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI field and editor improvements #1445

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Feb 4, 2025

  • Our example semantic domains claimed they were predefined, but did not use predefined Guids. So, for some I picked predefined Guids from the canonical list and for others I marked them as not predefined, so we're testing both kinds. It's a bit weird, that our "predfined" SemDoms don't match their predfined names, but 🤷.
  • I renamed the "hide" css classes to "unused", because that seemed slightly more appropriate now that it's not just a simple is-empty check. "Unused" wouldn't be bad in the UI either. But, Empty seems fine. I hope there wasn't a much easier way to keep track of whether the fields had ever had a value.
  • Thought I had a smart trick to prevent page-width resizing when we hide overflow with a dialog open, but it was faulty. I left it in as a note.

Also hid the history button in the new-entry dialog:
image

Collapsing/hiding behaviour: (found a bit of a bug at the end, but it's non-trivial and non-critical 😆)

Example-Project-dev-2025-02-04-09-20-45-727.-.Google.Chrome.2025-02-04.10-41-29.mp4

Scrolling up behaviour:

Example-Project-dev-2025-02-04-09-20-45-727.-.Google.Chrome.2025-02-04.10-43-11.mp4

Copy link

github-actions bot commented Feb 4, 2025

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 67717dd. ± Comparison against base commit 3dca3d1.

Copy link

github-actions bot commented Feb 4, 2025

C# Unit Tests

104 tests  ±0   104 ✅ ±0   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 67717dd. ± Comparison against base commit 3dca3d1.

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge it, we can try to make the makeHasHadValueTracker better later.

In your video you showed an example without any fields. Does that make sense? maybe each editor should have a primary field which never hides? So many exceptions.

@myieye myieye merged commit 876e72f into develop Feb 4, 2025
24 checks passed
@myieye myieye deleted the ui-field-and-editor-improvements branch February 4, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants