Improve app-bar and fix test and svelte-check

frontend/src/lib/layout/AppBar.svelte

@@ -13,7 +13,7 @@
   });
   let isPlaywright = false;
   let environmentName = env.PUBLIC_ENV_NAME?.toLowerCase();
-  export let user: LexAuthUser | undefined;
+  export let user: LexAuthUser | null;
   $: loggedIn = !!user;
 </script>
 

frontend/src/lib/layout/Layout.svelte

@@ -35,7 +35,7 @@
 
 <svelte:window on:keydown={closeOnEscape} />
 
-{#if user && user.audience == 'LexboxApi'}
+{#if user?.audience === 'LexboxApi'}
   <div class="drawer drawer-end grow">
     <input id="drawer-toggle" type="checkbox" bind:checked={menuToggle} class="drawer-toggle" />
 
@@ -94,7 +94,9 @@
     </div>
   </div>
 {:else}
-  <AppBar user={undefined} />
+  <!-- If the user is authenticated (i.e. not null), but not authorized to use the API, we
+  still want to pass them in here, so we show their name rather than Login and Register buttons. -->
+  <AppBar {user} />
 
   <Content>
     <slot />

frontend/src/lib/user.test.ts

@@ -1,6 +1,8 @@
 import {describe, expect, it} from 'vitest';
-import {jwtToUser} from '$lib/user';
+
 import type {AuthUserOrg} from '$lib/gql/generated/graphql';
+import {jwtToUser} from '$lib/user';
+
 describe('jwtToUser', () => {
   it('should convert a jwt token to a LexAuthUser', () => {
     const jwtUser = {
@@ -27,7 +29,7 @@ describe('jwtToUser', () => {
       'exp': 1722673515,
       'iat': 1721377515,
       'iss': 'LexboxApi',
-      'aud': 'LexboxApi'
+      'aud': 'LexboxApi' as const,
     };
     const user = jwtToUser(jwtUser);
     expect(user).toEqual({
@@ -66,7 +68,8 @@ describe('jwtToUser', () => {
       'canCreateProjects': true,
       'createdByAdmin': false,
       'locale': 'en',
-      'emailOrUsername': '[email protected]'
+      'emailOrUsername': '[email protected]',
+      'audience': 'LexboxApi',
     });
   });
 });

frontend/src/lib/user.ts

@@ -1,12 +1,12 @@
-import { browser } from '$app/environment'
-import { redirect, type Cookies } from '@sveltejs/kit'
-import { jwtDecode } from 'jwt-decode'
-import { deleteCookie, getCookie } from './util/cookies'
+import {browser} from '$app/environment';
+import {redirect, type Cookies} from '@sveltejs/kit';
+import {jwtDecode} from 'jwt-decode';
+import {deleteCookie, getCookie} from './util/cookies';
 import {hash} from '$lib/util/hash';
-import { ensureErrorIsTraced, errorSourceTag } from './otel'
+import {ensureErrorIsTraced, errorSourceTag} from './otel';
 import zxcvbn from 'zxcvbn';
-import { type AuthUserProject, type AuthUserOrg, ProjectRole, UserRole, type CreateGuestUserByAdminInput, type OrgRole } from './gql/types';
-import { _createGuestUserByAdmin } from '../routes/(authenticated)/admin/+page';
+import {type AuthUserProject, type AuthUserOrg, ProjectRole, UserRole, type CreateGuestUserByAdminInput, type OrgRole, LexboxAudience as GqlLexboxAudience} from './gql/types';
+import {_createGuestUserByAdmin} from '../routes/(authenticated)/admin/+page';
 
 type LoginError = 'BadCredentials' | 'Locked';
 type LoginResult = {
@@ -24,6 +24,8 @@ type RegisterResponseErrors = {
   }
 }
 
+type ApiLexboxAudience = 'LexboxApi' | 'Unknown';
+
 type JwtTokenUser = {
   sub: string
   name: string
@@ -36,7 +38,7 @@ type JwtTokenUser = {
   unver?: boolean | undefined,
   mkproj?: boolean | undefined,
   creat?: boolean | undefined,
-  aud: string,
+  aud: ApiLexboxAudience,
   loc: string,
 }
 
@@ -54,7 +56,7 @@ export type LexAuthUser = {
   emailVerified: boolean
   canCreateProjects: boolean
   createdByAdmin: boolean
-  audience: string
+  audience: ApiLexboxAudience
   locale: string
 }
 
@@ -156,6 +158,7 @@ export async function createGuestUserByAdmin(password: string, passwordStrength:
     canCreateProjects: responseUser.canCreateProjects ?? false,
     createdByAdmin: responseUser.createdByAdmin ?? false,
     emailOrUsername: (responseUser.email ?? responseUser.username) as string,
+    audience: responseUser.audience === GqlLexboxAudience.LexboxApi ? 'LexboxApi' : 'Unknown',
   }
   return { user }
 }

frontend/src/routes/(authenticated)/admin/+page.ts

@@ -260,6 +260,7 @@ export async function _createGuestUserByAdmin(input: CreateGuestUserByAdminInput
                 orgId
                 role
               }
+              audience
             }
             errors {
                 __typename