Fix synonyms pagination #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are removing params sanitization since Algolia already validates it. With that we can keep the lib as thin as possible and as close as possible with the documentation.
britto
reviewed
Mar 9, 2020
| {:ok, %{"hits" => hits, "nbPages" => pages}} when page + 1 < pages -> | ||
| page_hits(hits) | ||
|
|
||
| {:ok, %{"hits" => hits, "nbHits" => nbHits}} when page + 1 < nbHits / hits_per_page -> |
There was a problem hiding this comment.
Is this an edge case when Algolia doesn't return nbPages in their response JSON?
britto
reviewed
Mar 9, 2020
| * - `consequence` Required at least 1 [consequence](https://www.algolia.com/doc/api-reference/api-methods/save-rule/?language=javascript#method-param-consequence-2) | ||
| * -- `params`: Additional search parameters. Any valid search parameter is allowed. | ||
| * -- `promote`: List with objects to promote as hits. | ||
| * --- `objectID` |
There was a problem hiding this comment.
This is pretty cool. How does it look like in ex_doc's output?
britto
approved these changes
Mar 9, 2020
davidbrusius
approved these changes
Mar 10, 2020
|
Hi @sikanhe 👋 - can you help us in the review of this PR, please? 🙂 |
|
Hi I am looking for a new owner/maintainer. I have not used Elixir in over three years |
|
Hi @sikanhe - Thanks for your answer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the pagination of the synonyms list returned by synonyms/search endpoint.
This endpoint only returns the total number of hits instead of the number of pages
It also incorporates the changes from previous PR.
Note: The query rule is a paid feature, and since I don't have a paid personal key I also opened the PR as draft to run the test suite.