-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial attempt to make drupalpod compatible with Drupal 11 #144
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
WalkthroughThis update introduces significant upgrades to the development environment, transitioning to newer versions of key components. Specifically, it moves from Drupal 10 to 11, upgrades PHP from version 8.1 to 8.3, and shifts MariaDB from version 10.4 to 10.6. Alongside, it includes various minor adjustments to enhance the setup, ensuring compatibility and leveraging the latest features and improvements offered by these updates. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .ddev/config.yaml (1 hunks)
Additional comments: 3
.ddev/config.yaml (3)
- 2-2: The
type
field has been updated todrupal11
to reflect compatibility with Drupal 11. This change aligns with the PR's objective of updating DrupalPod for Drupal 11.- 4-4: The
php_version
has been updated to"8.3"
. This is a necessary update to ensure compatibility with Drupal 11 and to leverage the performance and security improvements of PHP 8.3. However, it's important to verify that all PHP dependencies and custom code within the DrupalPod environment are compatible with PHP 8.3.- 11-11: The
database.version
has been updated to"10.6"
. This update is crucial for ensuring compatibility with Drupal 11 and taking advantage of the new features and improvements in MariaDB 10.6. It's recommended to verify that the database schema and any custom SQL queries used within the DrupalPod environment are fully compatible with MariaDB 10.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .ddev/config.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .ddev/config.yaml
This still leads to the following error, but manual site installation works on Drupal 11-dev.
|
Thanks to Gábor's work on this, I could guide a few people making these changes manually when running DrupalPod both via the extension and not to get working environments. |
The Problem/Issue/Bug
How this PR Solves The Problem
Manual Testing Instructions
Related Issue Link(s)
Release/Deployment notes
Summary by CodeRabbit