Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix web/core not symlinked to repos/drupal/core #135

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

shaal
Copy link
Owner

@shaal shaal commented Oct 5, 2023

Summary by CodeRabbit

  • Refactor: Updated composer.json and vendor directory to resolve conflicts and ensure compatibility.
  • Chore: Created a symlink from repos/drupal/vendor to ../../vendor for easier access to dependencies.
  • Documentation: Updated composer.lock file using composer update --lock to reflect the latest package versions.

@shaal shaal self-assigned this Oct 5, 2023
@codesandbox
Copy link

codesandbox bot commented Oct 5, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2023

Walkthrough

The changes include modifications to the composer.json file and the vendor directory in the .gitpod/drupal/drupalpod-setup/drupal_setup_core.sh script. The conflict part is removed from composer.json, the composer.lock file is updated using composer update --lock, and a symlink is created from repos/drupal/vendor to ../../vendor.

Changes

File Summary
.gitpod/drupal/drupalpod-setup/drupal_setup_core.sh Modifies composer.json by removing conflicts, updates composer.lock, and creates a symlink for the vendor directory.

"A change to composer's tune,
Conflict resolved, harmony soon.
Composer lock, updated with care,
Symlink created, vendor's path fair."


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

@ghost
Copy link

ghost commented Oct 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@shaal shaal merged commit 10d8e8a into main Oct 7, 2023
@shaal shaal deleted the core-not-symlinked branch October 7, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant