Minor cleanup as the years go by (docker-compose version, etc) #119
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
WalkthroughThis pull request primarily focuses on updating the DDEV setup for a Drupal 9 project, including PHP, MariaDB, and Node.js versions. It also introduces performance optimization strategies and modifies service ports. A new Changes
TipsChat with CodeRabbit Bot (
|
| router_http_port: "80" | ||
| router_https_port: "443" | ||
| xdebug_enabled: false | ||
| additional_hostnames: [] | ||
| additional_fqdns: [] |
There was a problem hiding this comment.
These just aren't useful to have in here
| database: | ||
| type: mariadb | ||
| version: "10.3" |
There was a problem hiding this comment.
Better to use current required version? Doesn't d10 require 10.4? It's now the default anyway.
| web_environment: [] | ||
| nodejs_version: "16" |
There was a problem hiding this comment.
18 is now the default
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (3)
- .ddev/config.yaml (11 hunks)
- .ddev/docker-compose.ports.yaml (1 hunks)
- .ddev/docker-compose.testing.yaml (1 hunks)
Files skipped from review due to trivial changes (3)
- .ddev/config.yaml
- .ddev/docker-compose.ports.yaml
- .ddev/docker-compose.testing.yaml
| @@ -1,5 +1,4 @@ | |||
| # Expose port 3000 and 5000 of DDEV's web container. | |||
| version: '3.6' | |||
| database: | ||
| type: mariadb | ||
| version: "10.3" | ||
| nfs_mount_enabled: false | ||
| mutagen_enabled: false |
There was a problem hiding this comment.
mutagen_enabled is no longer valid syntax
The Problem/Issue/Bug
I just took a quick pass through and noted a few things like needing to remove
versionfrom docker-composeSummary by CodeRabbit
chromedriverservice in the testing environment usingdrupalci/chromedriver:productionimage, enhancing testing capabilities.