Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PATH): add npm bin to path #38

Merged
merged 1 commit into from
Jul 26, 2016
Merged

feat(PATH): add npm bin to path #38

merged 1 commit into from
Jul 26, 2016

Conversation

kentcdodds
Copy link
Collaborator

What:

This will search for a local node_modules/.bin directory and attempt to add it to the PATH (in a cross-platform way using manage-path).

Why:

So people can use these just as they would normal npm scripts. The only case where the PATH doesn't actually contain the npm bin is when you run the p-s script directly (rather than using npm scripts). This is an edge case, but it's still handy

How:

Use find-up to find the node_modules/.bin and mange-path to add it to the PATH in a cross-platform way

Closes #27

This will search for a local node_modules/.bin directory and attempt to
add it to the PATH (in a cross-platform way using `manage-path`).

Closes #27
@codecov-io
Copy link

codecov-io commented Jul 26, 2016

Current coverage is 100% (diff: 100%)

Merging #38 into next will not change coverage

@@           next   #38   diff @@
=================================
  Files         7     7          
  Lines       137   143     +6   
  Methods       0     0          
  Messages      0     0          
  Branches      0     0          
=================================
+ Hits        137   143     +6   
  Misses        0     0          
  Partials      0     0          

Powered by Codecov. Last update a9a6a62...3ffb5c0

@kentcdodds
Copy link
Collaborator Author

LGTM

This can be merged into next anytime.

@kentcdodds kentcdodds merged commit eeb0f99 into next Jul 26, 2016
@kentcdodds kentcdodds deleted the pr/npm-bin branch July 26, 2016 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants