-
-
Notifications
You must be signed in to change notification settings - Fork 95
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(bin/p-s.js): Added the abbility to preload a module (#12)
* docs(contributing): Fix the ROADMAP.md uri * feat(bin/p-s.js): Added the abbility to preload a module You can know add the arguments --require or -r to preload a module before requiring the package-scripts.js * fix(bin/p-s.js): Fixed some spelling mistakes (I am so stupid) * docs(module-preload): Add documentation for the --require cmdline option Closes #13 * docs(errors_and_warnings): update the docs related to --require #12 (comment) and #12 (comment) * fix(bin): fix local modules with a relative path It now checks if the preloaded module is a relative path and resolves the path relative to the cwd. In addition the -r and --require cmdline options are properly get stripped away from the command which is executed. * refactor(bin): change from config.default to config.__esModule * refactor(bin): .substr(0, 1) to [0] #12 (comment)
- Loading branch information
Tim McGee
authored and
Kent C. Dodds
committed
May 20, 2016
1 parent
8330978
commit 3ecdaf1
Showing
6 changed files
with
45 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ecdaf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either this (most likely) or efb2645 broke external config loading.
See https://circleci.com/gh/nkbt/react-swap/71 or https://circleci.com/gh/nkbt/react-element-resize/7
3ecdaf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly. I used
node_modules/react-component-template/package-scripts.js
because otherwise it was not working =).I will change to
react-component-template/package-scripts.js
of course since it is now working fine =)3ecdaf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep just checked.
Before
p-s --config react-component-template/package-script
did not work, butnode_modules/react-component-template/package-scripts.js
did. Now it is the other way around.It is sort of a breaking change, thus major bump would be preferable. It's not a big issue, seems like I am the only one who uses
p-s
this way at the moment =)3ecdaf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I forgot it is not major yet =)
3ecdaf1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nkbt, really sorry about this. This was totally unintentional (also, it was efb2645 that broke you I think).
I've been meaning to publish 1.0.0. Normally that's where I start. I'll try to get something out at 1.0.0 soon so you can rely on proper semver and not worry about breakages. Thanks for your patience 👍