Separated PcapLiveDevice
statistics update worker under its own class.
#1785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR separates the logic related to the statistics update worker into its own subclass to improve readability.
The main changes include:
PCapStats
to be declared underinternal
namespace.getStatistics
toPcapHandle
that callspcap_stats
on the handle internally.StatisticsUpdateWorker
as a nested class under PcapLiveDevice to encapsulate a running statistics update worker thread.std::unique_ptr<StatisticsUpdateWorker>
member field, representing an active worker.