-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to reduce memory footprint in Aggregator #1391
base: develop
Are you sure you want to change the base?
Changes to reduce memory footprint in Aggregator #1391
Conversation
1ece418
to
aab7971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also suggest running formatting script as the pipeline is failing.
sh scripts/format.sh
@snehal-das can you run it with memory_callback with large number of rounds to see the impact of this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snehal-das Does this PR "fix" memory leak once and for all, or it only optimizes memory usage?
Signed-off-by: snehal-das <[email protected]>
Signed-off-by: snehal-das <[email protected]>
a75c1a1
to
147d017
Compare
@rahulga1 I've run these changes for 100-200 rounds with torch/mnist and torch/histology tests. I've also tested it with 32 collaborators to evaluate the impact of the change.
@MasterSkepticista The current state of code does not fix memory issues. It only reduces the footprint of the aggregator, but there is still a growth in overall memory usage with time, albeit at a slower rate. There are a couple more approaches being considered for this:
|
Changes made: