Skip to content

Switch to flit #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2021
Merged

Switch to flit #478

merged 3 commits into from
Mar 3, 2021

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep mentioned this pull request Jan 8, 2021
Closed
@ivirshup
Copy link
Member

ivirshup commented Mar 1, 2021

To check sure this won't cause CI problems after merging, can you start a pr on scanpy that makes the anndata-dev build point to this PR? We'll just delete that pr once this is ready.

@flying-sheep
Copy link
Member Author

Done, too bad such a nice issue number is wasted on it lol scverse/scanpy#1700

@flying-sheep flying-sheep requested a review from ivirshup March 1, 2021 09:30
@flying-sheep
Copy link
Member Author

flying-sheep commented Mar 1, 2021 •
edited
Loading

d339903 can probably be removed, see scverse/scanpy#1702

/edit: done, the commit is unnecessary

ivirshup
ivirshup approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, did you not have to update the azure setup?

@flying-sheep
Copy link
Member Author

flying-sheep commented Mar 3, 2021 •
edited
Loading

No need, it’s just standard pip usage (no -e) and didn’t contain python setup.py check.

If we want, we can add a build check later like scanpy has though!

flying-sheep added a commit that referenced this pull request Mar 3, 2021
@flying-sheep
Switch to flit (#478)
daa3354 
This reverts commit f8ed61f.
@flying-sheep flying-sheep merged commit f15fd94 into master Mar 3, 2021
flying-sheep added a commit that referenced this pull request Mar 3, 2021
@flying-sheep
Switch to flit (#478)
4238f6b 
This reverts commit f8ed61f.
@flying-sheep flying-sheep deleted the flit branch March 3, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivirshup ivirshup ivirshup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flying-sheep @ivirshup