Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default raster smoothing to false for Scratch #23

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Default raster smoothing to false for Scratch #23

merged 1 commit into from
Nov 13, 2018

Conversation

fsih
Copy link

@fsih fsih commented Nov 5, 2018

Fixes scratchfoundation/scratch-paint#758

Scratch always wants crisp bitmaps

@fsih fsih added this to the November 2018 milestone Nov 5, 2018
@fsih fsih requested a review from cwillisf November 5, 2018 20:21
cwillisf
cwillisf approved these changes Nov 13, 2018
View reviewed changes
Copy link

@cwillisf cwillisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks too easy... does it really fix the problem? :D

@cwillisf cwillisf assigned fsih and unassigned cwillisf Nov 13, 2018
@fsih
Copy link
Author

fsih commented Nov 13, 2018 •
edited
Loading

Fortunately, for our bitmap editor we just always want this value to be false.

Here is the commit that brought this into Paper, by the way:
paperjs@1443701

@fsih fsih merged commit f69748f into scratchfoundation:develop Nov 13, 2018
@fsih fsih deleted the rasterSmoothing branch November 13, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwillisf cwillisf cwillisf approved these changes

Assignees

@fsih fsih

Labels
pr - good to merge
Projects
None yet
Milestone
November 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@fsih @cwillisf