Fix for #2533 Products which in stock aren't added to cart from Wishlist if user has products out of stock in Wishlist #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to cart from Wishlist if user has products out of stock in Wishlist
yeegor
suggested changes
Jun 1, 2021
| foreach ($wishlistItems as $item) { | ||
| $product = $item['product']; | ||
| $cartItems = $quote->getItems(); | ||
| $addedQty = false; |
There was a problem hiding this comment.
Naming addedQty implies having a quantity stored in that variable. Despite this, a boolean value is stored.
|
|
||
| $data = json_decode($item['buy_request'], true); | ||
| $allItemsStatus = false; |
There was a problem hiding this comment.
This naming is not verbose - it is impossible to understand what this is a flag for. Please rename.
| try { | ||
| if ($shouldShowError){ | ||
| throw new GraphQlInputException("error"); |
There was a problem hiding this comment.
Please provide an actual error message here.
Comment on lines
130
to
131
| $buyRequest = new DataObject(); | ||
| $buyRequest->setData($data); |
There was a problem hiding this comment.
What is this for? Maybe it's possible to get rid of this? Seems like you pass an empty array there, why is it necessary?
There was a problem hiding this comment.
This seems to have been here before my changes.
…ed to cart from Wishlist if user has products out of stock in Wishlist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: scandipwa/scandipwa#2533
Problem was that in stock items are not adding to cart from wishlist when there are out of stock items in it and not showing notifications correctly. This is the BE part of the fix. The FE part: scandipwa/scandipwa#2668