#7320 fix package rename #7339
Open
#7320 fix package rename #7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgodzik this is my first attempt to fix problem. let me know if this is going in right direction |
|
It looks like the correct approach. The tests are failing, but it looks like a matter or ordering them. Not sure why the mac OS order is different and it's not failling 🤔 After finishing, you can run |
pshemass
force-pushed
the
package_rename_fix
branch
from
ee83f7d to
e59f02e
Compare
|
@tgodzik I rerun all failed test locally and all pass. Is this just flaky? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for package rename #7320