Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: set diagnostic collection name #1576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

improvement: set diagnostic collection name #1576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/metals-vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@
const canRetryWithJar =
javaHome && !coursier.endsWith(".jar") && !forceCoursierJar;

function retry(error: any): Promise<any> {

Check warning on line 249 in packages/metals-vscode/src/extension.ts

View workflow job for this annotation

GitHub Actions / Eslint 

Unexpected any. Specify a different type

Check warning on line 249 in packages/metals-vscode/src/extension.ts

View workflow job for this annotation

GitHub Actions / Eslint 

Unexpected any. Specify a different type
if (canRetryWithJar) {
outputChannel.appendLine(
"Trying again with the embedded coursier. This might take longer."
Expand Down Expand Up @@ -286,7 +286,7 @@
serverProperties,
javaConfig,
serverVersion
).catch((reason): Promise<any> => {

Check warning on line 289 in packages/metals-vscode/src/extension.ts

View workflow job for this annotation

GitHub Actions / Eslint 

Unexpected any. Specify a different type
outputChannel.appendLine(
"Launching Metals failed with the following:"
);
Expand Down Expand Up @@ -406,6 +406,7 @@
markdown: {
isTrusted: true,
},
diagnosticCollectionName: "Metals",
};

function hoverLinksMiddlewareHook(
Expand Down