-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: -no-link-warnings does not work (#17028)
## Goal There are two purposes to this PR, the first is to add warning suppression when the path to the file is inneficient and a warning suppression flag is set. The second one is to deprecate the current flag and introduce a new to avoid the ambiguity. One for dead links with the current meaning, and one with dead links in assets. The goal is to avoid the confusion with overloading of the naming. I wonder if I also change the name of the previous flag to be more precise in its use. ## Flags noLinkWarnings - Boolean "-no-link-warnings", "Avoid warnings for ambiguous and incorrect links in members look up. Doesn't affect warnings for incorrect links of assets etc." noLinkAssetWarnings - Boolean "-no-link-asset-warnings", "Avoid warnings for incorrect links of assets like images, static pages, etc.", false ## Before : <img width="700" alt="Screenshot 2023-03-13 at 16 25 03" src="https://user-images.githubusercontent.com/44496264/224748941-65f08ba5-0498-4a0c-82b4-38b3921fcddd.png"> ## After : <img width="700" alt="Screenshot 2023-03-13 at 16 28 02" src="https://user-images.githubusercontent.com/44496264/224748976-dcd1825b-e4e7-48b4-b093-cc4f86a78fb0.png"> Fixes #16694
- Loading branch information
1 parent
b614d84
commit be70d46
Showing
4 changed files
with
16 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters