remove some defer statements

sandeepsukhani · Jun 25, 2024 · b15b78c · b15b78c
1 parent d2cb08e
commit b15b78c
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/pkg/compactor/retention/retention.go b/pkg/compactor/retention/retention.go
@@ -376,7 +376,6 @@ func (c *chunkRewriter) rewriteChunk(ctx context.Context, ce ChunkEntry, tableIn
 	})
 	defer func() {
 		newChunkData.(*chunkenc.MemChunk).Reset()
-		newChunkData = nil
 	}()
 	if err != nil {
 		if errors.Is(err, chunk.ErrSliceNoDataInRange) {
@@ -404,9 +403,6 @@ func (c *chunkRewriter) rewriteChunk(ctx context.Context, ce ChunkEntry, tableIn
 		newChunkStart,
 		newChunkEnd,
 	)
-	defer func() {
-		newChunk = chunk.Chunk{}
-	}()
 
 	encBuf := chunkEncodeBufferPool.Get().(*bytes.Buffer)
 	defer func() {
@@ -425,11 +421,7 @@ func (c *chunkRewriter) rewriteChunk(ctx context.Context, ce ChunkEntry, tableIn
 
 	// upload chunk only if an entry was written
 	if uploadChunk {
-		temp := []chunk.Chunk{newChunk}
-		defer func() {
-			temp = nil
-		}()
-		err = c.chunkClient.PutChunks(ctx, temp)
+		err = c.chunkClient.PutChunks(ctx, []chunk.Chunk{newChunk})
 		if err != nil {
 			return false, false, err
 		}