Lightos - DONT MERGE #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to do this without including |
…ing-for-better-performance Update CameraSession+Photo.kt for custom image saving
…eardown Lightos finish processing photos before teardown
Lightos config jpeg quality
…rom-photo Lightos return promise from photo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- not to be merged in, we're importing this branch into LightOS --
Also note: In order to get this package importing properly with TS I had to remove /package/lib/* from .gitignore. These files are all autogenerated when build a release so can be ignored when code reviewing
This PR adds the ability to lock the focus and exposure to a point on the screen. Once locked, the camera can be moved around and the original exposure and focus will be maintained. This also maintains it for photo taking. Once unlocked the camera returns to normal functionality.
In the end, the real solution lay in an SO anwser with 0 upvotes. I only found it because I googled a setting that copilot had hallucinated.
I was in the middle of documenting some of the paths that I'd already investigated while trying to get this working and I've left some of that documentation in. I'm happy to pull it out and put it in an experimental branch if needed. I'd dug way too deep into RNVC, camerax and camera2 to get to this point so maybe these can serve as warning for future improvements.
Recording.2024-11-26.145640-focus-lock.mp4