DRAFT DO NOT MERGE: 🎁 Flexible double combo #6843
Draft
+4,983
−353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work solely focused on the UI elements needed to build out the ability to import a metadat profile. This heavily relies on backend functionality to complete.
In this commit, we test that a module is included when the HYRAX_FLEXIBLE env var is set. Issue: - notch8/amigos#20
This commit will relocate the Metadata Profiles link to Repository Content. We also refactor the modal to make it show up better.
A fix to solr_document behavior to find the correct model: This enables us to have both models which are lazy migrating and new models which are native Valkyrie in the same app. A fix to the Freyja persister to handle lazy migration of members The Freyja persister was submitting empty MigrateResourcesJobs because it didn't check if there were any members to migrate before submitting.
When lazy migration is used, the sipity entity cannot be found for works which are not yet migrated. Valkyrie resources have a `proxy_for_global_id` with the format: `gid://hyku/Hyrax::ValkyrieGlobalIdProxy/2f6da5dd-9314-421f-b0dd-fda84fec9ee3` while prior works used the model name such as: `gid://hyku/GenericWork/2f6da5dd-9314-421f-b0dd-fda84fec9ee3`. This commit introduces a lazy migration of the sipity entity via a job which is submitted after a work is migrated to valkyrie via the Freyja persister. Prior work in pull request samvera/hyku#2471 added some overrides in Hyku to resolve the sipity entity issues. These changes still needs to be backported. The prior work includes these changes: The MigrateResourceService introduced a migration of the entity along with the work's migration. This service is needed for direct migration calls, but is not adequate for lazy migration, as the Freyja persister does not call it for the work itself that was just migrated. Hyku overrides to sipity.rb support cases where the entity is not yet migrated and lazy migration is in use. This is necessary because the solr_document is used to find the Sipity::Entity. Due to the model mapping found in the solr document, the Entity method searches for the entity with the model name. This is problematic when the entity is not yet migrated and the entity is searched with a GenericWorkResource model rather than the model.
…-work Lazy migrate sipity entity with work
We don't know until we try ActiveFedora whether there is might be a problem with the sipity entry. We should not rerun the job 5 times when the work was never in Fedora.
And a schema change came through as well.
This will allow us to reference Hyrax releases from Hyku
Move simple work to lib
DRY types do not work with try? method. This is a fix to the fix.
Revising how the attributes_helper works to find the schema requires additional setup in a number of specs. GenericWork wasn't showing in the map value used to find the model for the schema. Plus a couple other minor spec fixes.
Use wings only if wings is available.
Finding the attributes depends on which class we have. This adds more fallback methods to find the right class & make sure we can display the works.
Adds more options into attributes_helper
The method of handling the javascript doesn't work with the view specs. The code works correctly in the UI. Additional work is needed to fix these.
Issue may be related to the reason why based_near specs are failing. In the UI he user is required to click "add another location" first, which the spec doesn't account for. We need to figure out why this changed and fix it (instead of updating the spec). ref: - de8b98a
This was the reason the location dropdown wasn't readily available when creating a new work.
This reverts commit 4dfc7b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is the working branch for all things flexible metadata related.