SALTO-7433: fixing default value for contexts #7246
Conversation
packages/jira-adapter/src/filters/fields/context_options_deployment_filter.ts
Outdated
Show resolved
Hide resolved
| } | ||
| const optionsIdByElemId: Record<string, string> = Object.fromEntries( | ||
| addedOptionInstances.map(option => [option.elemID.getFullName(), option.value.id]), | ||
| ) |
There was a problem hiding this comment.
IIUC if the option deployment failed, this option.value.id will be undefined
There was a problem hiding this comment.
Moved the function, should not be called in failures
IdoZakk
force-pushed
the
7433DefaultValuesCascade
branch
from
ccd9dfa to
97674a1
Compare
packages/jira-adapter/src/filters/fields/context_options_deployment_filter.ts
Outdated
Show resolved
Hide resolved
packages/jira-adapter/src/filters/fields/context_options_deployment_filter.ts
Outdated
Show resolved
Hide resolved
packages/jira-adapter/src/filters/fields/context_options_deployment_filter.ts
Outdated
Show resolved
Hide resolved
packages/jira-adapter/src/filters/fields/context_options_deployment_filter.ts
Outdated
Show resolved
Hide resolved
packages/jira-adapter/src/filters/fields/context_options_deployment_filter.ts
Outdated
Show resolved
Hide resolved
| .map(path => _.get(defaultValues, path)) | ||
| .filter(isReferenceExpression) | ||
| .find( | ||
| value => value.value.id == null, // undefined or null |
There was a problem hiding this comment.
I wonder in which case it can be null?
usually in the oss we do not check for nulls
There was a problem hiding this comment.
I saw that in the values sent to the service and did not want to take a risk. It is possible it was a Json translation
|
|
||
| const contextChange = getContextChange(leftoverChanges, contextId) | ||
| if (contextChange === undefined) return | ||
| const optionReferenceWithoutId = findOptionWithoutId(contextChange) |
There was a problem hiding this comment.
it is possible that some options will be without id, then our message wont be accurate. Im not sure we should change this.
and IMO it worth to add a comment like:
a single option without id is enough for a context failure
There was a problem hiding this comment.
I think that stating one is enough, I do not think we should state all options that failed
packages/jira-adapter/src/filters/fields/context_options_deployment_filter.ts
Outdated
Show resolved
Hide resolved
Fixed default values- the value of the references for options in the default value was not updated in add
Tests will follow
Release Notes:
Jira Adapter:
User Notifications:
None