SALTO-4207: Missing reference in FlexiPage criterias #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelly
reviewed
Feb 12, 2025
| @@ -60,8 +61,8 @@ describe('changeValidator', () => { | |||
| metadataType: ITEM_INSTANCE, | |||
| }, | |||
| fields: { | |||
| [COMPONENT_INSTANCE_FILED_NAMES.COMPONENT_INSTANCE_PROPERTIES]: { | |||
| refType: new ListType(componentInstanceProperty), | |||
| [ITEM_INSTANCE_FIELD_NAMES.COMPONENT]: { | |||
There was a problem hiding this comment.
It’s not a bug, the structure of the mocked Flow instance doesn’t affect the functionality. I wanted the structure to be correct, and apparently, ItemInstance contains a single ComponentInstance rather than an array of instances: here
Comment on lines
1039
to
1041
| expect(componentInstanceCreatedReference).toBeInstanceOf(ReferenceExpression) | ||
| expect(itemComponentInstanceCreatedReference).toBeInstanceOf(ReferenceExpression) | ||
| expect(fieldInstanceCreatedReference).toBeInstanceOf(ReferenceExpression) |
There was a problem hiding this comment.
Don't we want to check we got the right reference?
AlmogMesilaty
force-pushed
the
SALTO-4207
branch
from
7455508 to
7b3fcb2
Compare
yelly
approved these changes
Feb 13, 2025
AlmogMesilaty
force-pushed
the
SALTO-4207
branch
from
7b3fcb2 to
e0ab514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SALTO-4207: Missing reference in FlexiPage criterias
Workspace Diff: salto-io/almog-sf@75f4631#diff-bf6841af5dcdd8f35c9cacd4cbee8c00d31a550c52f2d40ab84298d222163cc8
Release Notes:
Salesforce Adapter:
User Notifications:
Salesforce Adapter: