SALTO-7363: Removing unused exports in Jira adapter #7234
Conversation
| export const findObjects = (elements: Element[], names: string[]): ObjectType[] | undefined => { | ||
| const types = elements.filter(isObjectType).filter(element => names.includes(element.elemID.name)) | ||
|
|
||
| if (types.length !== names.length) { | ||
| const missingTypes = names.filter(name => !types.map(t => t.elemID.name).includes(name)).join(', ') | ||
| log.warn(`could not find the following objects: ${missingTypes}`) | ||
| return undefined | ||
| } | ||
| return types | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a util function, I would like to keep it
There was a problem hiding this comment.
But no one uses it ever, so it's obviously not so useful...
Also, knip won't allow us to keep it exported (that's the point) and TS won't allow us to keep it unexported, so the only real way to keep this is either to comment it out or export it from the main index.ts, both of which seem silly.
WDYT?
There was a problem hiding this comment.
Can't we add a comment to ignore this line like we do in lint?
There was a problem hiding this comment.
There isn't a line level ignore option in knip and ignoring the whole file is overkill IMO.
I guess we could use a @ts-ignore directive which is a bit dangerous (because it suppresses all ts checks). I'll try it out.
Do you really think these functions will be used in the future though? My prior is that utility functions that aren't used now will never be used in most cases.
There was a problem hiding this comment.
Can a file be ignored only for one rule? if so, I think util files are OK to be ignored.
I reviewed those functions again and I am OK with removing them
There was a problem hiding this comment.
Regrettably it's all or nothing.
If we face this with functions we actually want to keep we'll work this out.
| export const getDefaultAdapterConfig = async (): Promise<JiraConfig> => { | ||
| const defaultConfigInstance = await createDefaultInstanceFromType('jira', configType) | ||
| return defaultConfigInstance.value as JiraConfig | ||
| } | ||
|
|
There was a problem hiding this comment.
I would like to keep this util functions
There was a problem hiding this comment.
But no one uses it ever, so it's obviously not so useful...
Also, knip won't allow us to keep it exported (that's the point) and TS won't allow us to keep it unexported, so the only real way to keep this is either to comment it out or export it from the main index.ts, both of which seem silly.
WDYT?
Preparation for enabling unused exports rules in knip.
Additional context for reviewer
Release Notes:
None.
User Notifications:
None.