SALTO-7409: Handle "INSUFFICIENT_ACCESS: insufficient access rights on entity" errors in retrieve #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelly
reviewed
Feb 10, 2025
| const errorPattern = /INSUFFICIENT_ACCESS: insufficient access rights on entity: (\w+)/g | ||
| const matches = [...error.message.matchAll(errorPattern)] | ||
| if (matches.length > 0) { | ||
| matches.forEach(match => { |
There was a problem hiding this comment.
How can there be multiple matches?
| typesWithInsufficientAccess.add(failedEntity) | ||
| }) | ||
| const updatedFilesToRetrieve = CurrentFilesToRetrieve.filter( | ||
| fileProp => ![...matches.map(match => match[1])].includes(fileProp.type), |
There was a problem hiding this comment.
This will also be simpler once you assume there's only 1 match.
| fileProp => ![...matches.map(match => match[1])].includes(fileProp.type), | ||
| ) | ||
| if (updatedFilesToRetrieve.length === 0) { | ||
| throw new Error('No files left to retrieve after filtering out failed entities') |
There was a problem hiding this comment.
Why is this an error? Just return...
| const result = await client.retrieve(request) | ||
|
|
||
| const typesWithInsufficientAccess = new Set<string>() | ||
| const retrieveWithRetry = async ( |
There was a problem hiding this comment.
Not a great name because the real functionality this function provides is not the retry but rather the handling of types with insufficient access.
Maybe call it retrieveAccessibleEntities or something like that.
| configChanges.push( | ||
| createSkippedListConfigChange({ | ||
| type: entity, | ||
| reason: `Insufficient access rights on entity: ${entity}`, |
There was a problem hiding this comment.
This can be written in more Salto language by using "type" instead of "entity".
| types: [mockTypes.CustomObject, mockTypes.Flow, mockTypes.Opportunity], | ||
| fetchProfile, | ||
| }) | ||
| // expect(elements).toHaveLength(2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SALTO-7409: Handle "INSUFFICIENT_ACCESS: insufficient access rights on entity" errors in retrieve
Release Notes:
None
User Notifications:
None