SALTO-7363: Removing unused exports from all non-adapter packages #7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,4 +6,3 @@ | |||
| * CERTAIN THIRD PARTY SOFTWARE MAY BE CONTAINED IN PORTIONS OF THE SOFTWARE. See NOTICE FILE AT https://github.com/salto-io/salto/blob/main/NOTICES | |||
| */ | |||
| export { createClientDefinitions } from './clients' | |||
| export { PAGINATION as pagination } from './pagination' | |||
There was a problem hiding this comment.
Didn't review the rest of the PR, but please don't remove things from service placeholder as this serves as a placeholder to create a new adapter
There was a problem hiding this comment.
I've removed the service placeholder adapter from this PR, we will work out how to handle it separately.
yelly
force-pushed
the
SALTO-7363-core
branch
from
bf4cffe to
46311ac
Compare
ori-moisis
approved these changes
Feb 12, 2025
| @@ -29,6 +29,9 @@ import { | |||
| getSalesforceClient, | |||
| } from './helpers/salesforce' | |||
| import * as callbacks from '../src/callbacks' | |||
| // Importing getCredentialsFromUser since this file is the only place it's used but it's only referenced by name for spying | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| import { getCredentialsFromUser as _getCredentialsFromUser } from '../src/callbacks' | |||
There was a problem hiding this comment.
do we need both the lint disable and the as thing?
There was a problem hiding this comment.
Yes, not using a declared variable not starting in an underscore is a TS warning, not an eslint one.
If we want to not do the rename we would need to use a @ts-ignore directive instead of an eslint-disable directive which is more dangerous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for enabling knip unused exports rules.
Additional context for reviewer
Release Notes:
None.
User Notifications:
None.