-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SALTO-7225: Change the elemID of dashboards to contain the user id #7212
Conversation
e5055ae
to
103b338
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this cause significant diffs across environments ? do we expect users to be aligned between envs ?
Did we consider doing this only when there is a collision ?
It is, I'm going to merge it only after i will get a confirmation from CS, users will need to run a fetch with regenerateSaltoIds |
I'm really not in the details of this and i'm not sure what research was done, but misaligned ids can cause lots of other issues. If it's really the only choice, I would consider the option to "fallback" to user id in the element id, only in the case of a collision. |
I think fallback will result in more collisions. There is a problem around deployments- we cannot deploy the owner of a dashboard, so deploying a dashboard made by another user will still appear as a difference after a deployment. I think the current situation of collisions is not a good UX.
I think 1 is the best value/time, and if customers start to experience issues because they did not perform the post action we can implement 2. |
@IdoZakk we're planning to apply this change to the customers who got this collision, and instruct them to fetch with regenerate ids on all their envs |
Added idFields to generate an elemId composed of the dashboard name and the owner's name.
Release Notes:
Jira_adapter:
User Notifications:
Jira_adapter: