SALTO-7272: Compute config changes with calculateDiff instead of getPlan
#7187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nurdok
force-pushed
the
feature/SALTO-7272
branch
from
1694c5c to
6bd2b49
Compare
Comment on lines
+1011
to
+1013
| if (getSaltoFlagBool(WORKSPACE_FLAGS.replaceGetPlanWithCalculateDiff)) { | ||
| log.trace('Using calculateDiff instead of getPlan to compute config changes') | ||
| } |
There was a problem hiding this comment.
nit: I think this one is redundant as we're already printing the flags elsewhere
There was a problem hiding this comment.
Where? I couldn't find the flag name in the trace log.
packages/core/src/core/fetch.ts
Outdated
| }), | ||
| ).toArray() | ||
| : [ | ||
| ...( |
There was a problem hiding this comment.
can we use Array.from instead? (same for line 1032)
packages/core/src/types.ts
Outdated
| @@ -34,7 +33,7 @@ export type FetchResult = { | |||
| mergeErrors: MergeErrorWithElements[] | |||
| fetchErrors: SaltoError[] | |||
| success: boolean | |||
| configChanges?: Plan | |||
| configChanges?: Change[] | |||
There was a problem hiding this comment.
This one is a breaking change, right ? (FetchResult in the return type of fetch in api.ts)
We should update the release notes + probably communicate this ?
There was a problem hiding this comment.
Updated the release notes.
shir-reifenberg
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of computing a plan to identify config changes, use the new
calculateDiffto get a simple list of changes instead.Additional context for reviewer:
I'm not sure this actually warrants a core flag, LMKWYT
Release Notes:
Core:
FetchResulttype changed itsconfigChangesparameter type fromPlantoChange[]User Notifications:
None