Renamed vector subspace complement to othrogonal_complement and changed the complement function #39659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31487. Added the change suggested by @DaveWitteMorris found in the comments of #31487. Changes the behavior of the
complement
function of vector subspaces. Instead of returning the orthogonal complement (which was the original behavior) it instead returns a subspace such that the direct sum of the two subspaces is the vector space itself. I haven't fully changes the behavior however. It still gives a deprecation message and returns the orthogonal complement unlessorthogonal=False
. Iforthogonal=True
then it does not print the deprecation message. I've also moved the original code for the orthogonal complement to it's own function namedorthogonal_complement
.Things that may still be needed: More/Better examples in the
complement
function. Inorthogonal_complement
I replaced everywhere it said "complement" with "orthogonal complement". In the last example that change might not be appropriate but I am unsure. A post in the sage forums to debate if this change should be made and if the function nameorthogonal_complement
makes sense.📝 Checklist
⌛ Dependencies