Overwrote methods concerning subdivision of edges in a matching covered graph #39650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 823c6a1; changes) is ready! 🎉 |
janmenjayap
changed the title
dcoudert
suggested changes
Mar 9, 2025
| sage: G.get_matching() | ||
| [(0, 3, None), (1, 2, None)] | ||
| sage: G.subdivide_edges(G.edges(), 2) | ||
| sage: G.edges() |
There was a problem hiding this comment.
This example is failing on some CI.
To avoid that: use a smaller example, don't show the list of edges, but the number of edges, etc.
| for edge in edges: | ||
| if isinstance(edge, tuple): | ||
| if len(edge) <= 1: | ||
| raise ValueError('need more than 1 value to unpack') |
There was a problem hiding this comment.
you should also print the edge to clarify the error message.
| raise ValueError('expected an iterable of edges, but got a non-iterable object') | ||
|
|
||
| for edge in edges: | ||
| if isinstance(edge, tuple): |
There was a problem hiding this comment.
sometimes, we use list or frozenset, etc. and not only tuples.
|
|
||
| if len(edge) == 2: | ||
| u, v = edge | ||
| if not self.has_edge(u, v): |
There was a problem hiding this comment.
this could be tested at the same time than the format of edges, no ?
Comment on lines
+3892
to
+3894
| M.add_edges( | ||
| [(new_vertices[i * k + j], new_vertices[i * k + j + 1], l) for j in range(0, k - 1, 2)] | ||
| ) |
There was a problem hiding this comment.
M.add_edges((new_vertices[i * k + j], new_vertices[i * k + j + 1], l)
for j in range(0, k - 1, 2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this issue is to overwrite the methods pertaining to subdivision of edges in a matching covered graph.
More specifically, this PR aims to overwrite the following methods:
subdivide_edge()| Subdivide an edgektimes.subdivide_edges()| Subdividektimes edges from an iterable container.This PR shall address the methods related to subdivision of edge(s) in matching covered graphs.
Fixes #38216.
Note that this issue fixes a small part of the mentioned issue.
📝 Checklist
⌛ Dependencies
Nothing as of now.
cc: @dcoudert.