Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .ci directory #39642

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

tobiasdiez
Copy link
Contributor

Removes the .ci folder. It contains mostly outdated scripts that were used for gitlab CI.

  • A few scripts are needed for building the docker image, they are moved to docker
  • A few other scripts are used in the current github ci, they are moved to .github/workflows

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tobiasdiez tobiasdiez requested a review from user202729 March 7, 2025 11:01
Copy link

github-actions bot commented Mar 7, 2025

Documentation preview for this PR (built with commit 8441838; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez tobiasdiez mentioned this pull request Mar 7, 2025
5 tasks
@user202729
Copy link
Contributor

user202729 commented Mar 7, 2025

Looks good to me. Though the permission change on sage-version.sh looks accidental.

Also not sure where docker-exec-script should belong (if it isn't used to build docker I assume putting there is fine? Might be worth creating a docker/README.md then)

@saraedum Are the removed scripts useless now?

@tobiasdiez
Copy link
Contributor Author

Also not sure where docker-exec-script should belong (if it isn't used to build docker I assume putting there is fine? Might be worth creating a docker/README.md then)

It's only used in the github ci that is based on docker. Not for building the docker image that we provide. Thus it is similar to write-dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants