fix typo in ladder_idempotent #39638
Open
+29
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 4950b1b; changes) is ready! 🎉 |
dcoudert
reviewed
Mar 7, 2025
| from sage.combinat.permutation import (Permutation, Permutations, | ||
| from_permutation_group_element) | ||
| from sage.combinat.permutation_cython import (left_action_same_n, | ||
| right_action_same_n) | ||
| from sage.combinat.partition import _Partitions, Partitions, Partitions_n |
There was a problem hiding this comment.
should be before permutation
| la = _Partitions(la) | ||
| if sum(la) != n: | ||
| raise ValueError(f"{la} is not a partition of {n}") | ||
| la = Partitions_n(n)(la) | ||
| Tlad, alpha = la.ladder_tableau(p, ladder_lengths=True) | ||
| if not all(val < p for val in alpha): |
There was a problem hiding this comment.
a detail: if any(val >= p for val in alpha):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that has currently a very wrong name
alos a few other minor details on the way
📝 Checklist