Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1:4.0: Use safe-singleton-factory for deployment #469

Merged
merged 1 commit into from
Dec 25, 2022
Merged

1:4.0: Use safe-singleton-factory for deployment #469

merged 1 commit into from
Dec 25, 2022

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Dec 24, 2022 •
edited
Loading

This PR:

@mmv08 mmv08 requested a review from a team December 24, 2022 11:10
@mmv08 mmv08 force-pushed the feat/use-safe-singleton-factory branch from 5d785dc to 1df6825 Compare December 24, 2022 11:11
@coveralls
Copy link

coveralls commented Dec 24, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3771077108

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.943%
Totals Coverage Status
Change from base Build 3766314145: 0.0%
Covered Lines: 298
Relevant Lines: 306
💛 - Coveralls

rmeissner
rmeissner approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@rmeissner rmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention in the description of the PR that we removed deprecated test networks with this PR ;)

@mmv08 mmv08 merged commit e364dee into main Dec 25, 2022
@mmv08 mmv08 deleted the feat/use-safe-singleton-factory branch December 25, 2022 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmeissner rmeissner rmeissner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @rmeissner