Fix regression when deps=False is set

ryanking13 · Jan 30, 2025 · 17650ad · 17650ad
1 parent 4728a85
commit 17650ad
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/micropip/transaction.py b/micropip/transaction.py
@@ -268,6 +268,8 @@ async def add_wheel(
             else:
                 await wheel_download_task
                 await self.gather_requirements(wheel.requires(extras))
+        else:
+            await wheel_download_task
 
         self.wheels.append(wheel)
 

diff --git a/tests/integration/test_integration.py b/tests/integration/test_integration.py
@@ -33,6 +33,28 @@ async def _run(selenium):
     _run(selenium_standalone_micropip)
 
 
+@integration_test_only
+def test_integration_install_no_deps(selenium_standalone_micropip, pytestconfig):
+    @run_in_pyodide
+    async def _run(selenium):
+        import micropip
+
+        await micropip.install("pytest-asyncio", deps=False)
+
+        import pytest_asyncio
+
+        try:
+            # pytest-asyncio depends on pytest
+            import pytest
+        except ImportError:
+            pass
+        else:
+            raise Exception("Should raise!")
+
+    _run(selenium_standalone_micropip)
+
+
+
 @integration_test_only
 def test_integration_list_basic(selenium_standalone_micropip, pytestconfig):
     @run_in_pyodide