Upgrade V8 to 7.2.502.16 (denoland#1403)

ry · Dec 23, 2018 · 9909e8a · 9909e8a
1 parent f8473bf
commit 9909e8a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/gclient_config.py b/gclient_config.py
@@ -1,6 +1,6 @@
 # Copyright 2018 the Deno authors. All rights reserved. MIT license.
 solutions = [{
-    'url': 'https://chromium.googlesource.com/v8/v8.git@7.1.302.4',
+    'url': 'https://chromium.googlesource.com/v8/v8.git@7.2.502.16',
     'name': 'v8',
     'deps_file': 'DEPS',
     'custom_deps': {

diff --git a/libdeno/BUILD.gn b/libdeno/BUILD.gn
@@ -1,6 +1,6 @@
 # Copyright 2018 the Deno authors. All rights reserved. MIT license.
-import("./deno.gni")
 import("//third_party/v8/gni/v8.gni")
+import("./deno.gni")
 
 config("deno_config") {
   include_dirs = [ "//third_party/v8" ]  # This allows us to v8/src/base/ libraries.

diff --git a/libdeno/api.cc b/libdeno/api.cc
@@ -154,9 +154,10 @@ int deno_respond(Deno* d_, void* user_data, int32_t req_id, deno_buf buf) {
 
   v8::Local<v8::Value> args[1];
   args[0] = deno::ImportBuf(d, buf);
-  recv_->Call(context->Global(), 1, args);
+  auto v = recv_->Call(context, context->Global(), 1, args);
 
   if (try_catch.HasCaught()) {
+    CHECK(v.IsEmpty());
     deno::HandleException(context, try_catch.Exception());
     return 1;
   }

diff --git a/third_party b/third_party