Added optional limit to mv method #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phstc
reviewed
Mar 21, 2017
| @@ -158,11 +158,11 @@ def requeue(queue_name, path) | |||
| desc 'mv QUEUE-NAME-SOURCE QUEUE-NAME-TARGET', 'Move messages from one queue (source) to another (target)' | |||
| method_option :number, aliases: '-n', type: :numeric, default: Float::INFINITY, desc: 'number of messages to move' | |||
| method_option :delete, aliases: '-d', type: :boolean, default: true, desc: 'delete from the queue' | |||
| def mv(queue_name_source, queue_name_target) | |||
| def mv(queue_name_source, queue_name_target, limit: nil) | |||
There was a problem hiding this comment.
@parov if feels like hacky doing that, it's a thor task, it's supposed to be called as a thor task. I wouldn't add an extra param, just for making it available for outside, the possible options:
- Invoke it as a thor task. See https://github.com/erikhuda/thor/wiki
- subprocess
system(bundle exec shoryuken sqs mv ...) - Extract this
mvto a class (not a thor one) and use this class here and in your controller
See #339 (comment)
There was a problem hiding this comment.
thanks @phstc. Sub-processing looks a good solution for this one time tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use the mv method from outside the CLI, we need to set the limit
Fix #339