Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing log verbosity #243

Merged
merged 1 commit into from
Sep 12, 2016
Merged

changing log verbosity #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/shoryuken/fetcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def fetch(queue, available_processors)
limit = batch ? FETCH_LIMIT : available_processors

if (sqs_msgs = Array(receive_messages(queue, limit))).any?
logger.info { "Found #{sqs_msgs.size} messages for '#{queue}'" }
logger.debug { "Found #{sqs_msgs.size} messages for '#{queue}'" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariokostelac WDYT about it? I kind of like this change, but it can mislead people that were used to these messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phstc @mariokostelac Is it really useful in production environment ? changing it to debug will not affect development environment, in the other hand, it will help a lot of people who are using paying solutions to manage logs ;-)
Not to mention the fact that we can analyze all the trafic for the last 2 weeks in the Amazon monitoring tab. And if we really want this kind of repetitive logs, it is very easy to add it in the worker.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sof31t I'm in favor of your change. I'm just wondering about people that are used to those logs, they might think something wrong is going on if they stop seeing it after a bump.


if batch
@manager.async.assign(queue, patch_sqs_msgs!(sqs_msgs))
Expand Down