Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1423] Fix an error for Rails/StrongParametersExpect #1424

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jan 20, 2025

This PR fixes an error for Rails/StrongParametersExpect when using permit with no arguments.

Fixes #1423.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This PR fixes an error for `Rails/StrongParametersExpect`
when using `permit` with no arguments.

Fixes rubocop#1423.
@koic koic merged commit 158cd38 into rubocop:master Jan 20, 2025
16 checks passed
@koic koic deleted the fix_an_error_for_rails_strong_parameters_expect branch January 20, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/StrongParametersExpect errors when permit does not have parameters
1 participant