Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): plugin type definitions not being exported correctly in ES… #1578

Closed
wants to merge 5 commits into from
Closed

fix(repo): plugin type definitions not being exported correctly in ES… #1578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c48fcc
fix(repo): plugin type definitions not being exported correctly in ES…
Geylnu Sep 6, 2023
1b5ab93
refactor(repo): modify the declaration file to be a self-contained
Sep 7, 2023
cc5eb20
Merge branch 'rollup:master' into master
Geylnu Sep 20, 2023
29d8b10
Merge branch 'rollup:master' into master
Geylnu Oct 24, 2023
bd5c070
Merge remote-tracking branch 'upstream/master'
benmccann Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/alias/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/auto-install/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/babel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
Geylnu marked this conversation as resolved.
Show resolved Hide resolved
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/buble/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/commonjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/data-uri/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/dsv/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/dynamic-import-vars/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/eslint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/esm-shim/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "dist/cjs/index.js",
"module": "dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/graphql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/image/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/inject/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/json/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/multi-entry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/node-resolve/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/pluginutils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
"module": "./dist/es/index.js",
"type": "commonjs",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/replace/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "dist/cjs/index.js",
"module": "dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/run/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/strip/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/sucrase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
"module": "./dist/es/index.js",
"type": "commonjs",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/swc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "dist/cjs/index.js",
"module": "dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/terser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "dist/cjs/index.js",
"module": "dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/url/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/virtual/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/wasm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
4 changes: 3 additions & 1 deletion packages/yaml/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"main": "./dist/cjs/index.js",
"module": "./dist/es/index.js",
"exports": {
"types": "./types/index.d.ts",
"types": {
"import": "./dist/es/index.d.ts"
},
"import": "./dist/es/index.js",
"default": "./dist/cjs/index.js"
},
Expand Down
16 changes: 15 additions & 1 deletion shared/rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { builtinModules } from 'module';
import { promises as fs } from 'fs';

// eslint-disable-next-line import/no-extraneous-dependencies
import typescript from '@rollup/plugin-typescript';
Expand Down Expand Up @@ -31,7 +32,7 @@ export function createConfig({ pkg, external = [] }) {
{
format: 'es',
file: pkg.module,
plugins: [emitModulePackageFile()],
plugins: [emitModulePackageFile(), emitDeclarationFile()],
Geylnu marked this conversation as resolved.
Show resolved Hide resolved
sourcemap: true
}
],
Expand All @@ -51,3 +52,16 @@ export function emitModulePackageFile() {
}
};
}

export function emitDeclarationFile() {
return {
name: 'emit-declaration-file',
async generateBundle() {
this.emitFile({
type: 'asset',
fileName: 'index.d.ts',
source: await fs.readFile('./types/index.d.ts')
});
}
};
}